Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #218 Switch base Docker image to python:3.6-alpine #239

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Issue #218 Switch base Docker image to python:3.6-alpine #239

wants to merge 3 commits into from

Conversation

danmoz
Copy link

@danmoz danmoz commented Jan 11, 2022

Upgrades the version of python, switching to the official Python Alpine base image (version 3.6). This resolves the following warning at startup:

PythonDeprecationWarning: Boto3 will no longer support Python 3.5 starting February 1, 2021. To continue receiving service updates, bug fixes, and security updates please upgrade to Python 3.6 or later. More information can be found here: https://aws.amazon.com/blogs/developer/announcing-the-end-of-support-for-python-3-4-and-3-5-in-the-aws-sdk-for-python-and-aws-cli-v1/

@danmoz danmoz changed the title Issue #218 Switch base image to python:3.6-alpine Issue #218 Switch base Docker image to python:3.6-alpine Jan 11, 2022
santoshamohan
santoshamohan reviewed May 3, 2022
View reviewed changes
Copy link

@santoshamohan santoshamohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider updating the base image to python:3.9.12-alpine3.15

Dockerfile Outdated
@@ -1,4 +1,4 @@
FROM alpine:3.5
FROM python:3.6-alpine
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python:3.6-alphine image is vulnerable to attacks. Can you consider updating to python:3.9.12-alpine3.15 and testing it?

@danmoz
Copy link
Author

danmoz commented May 3, 2022

Rebased my branch on master, updated to suggested image, tested locally. Seems to work fine.

I did note a new Python timezone warning which I don't recall seeing previously:

Please visit the following URL to view your CAPTCHA: https://accounts.google.com/Captcha?v=2&ctoken=AAWk9lS4******
Captcha (case insensitive): **********
Check your phone - after you have confirmed response press ENTER to continue.
Assuming arn:aws:iam::************:role/AdministratorAccess
/usr/local/lib/python3.9/site-packages/tzlocal/unix.py:177: UserWarning: Can not find any timezone configuration, defaulting to UTC.
  warnings.warn("Can not find any timezone configuration, defaulting to UTC.")

It seems correct to default to UTC, but it seems a shame to get rid of the PythonDeprecationWarning only to replace it with a UserWarning complaining about timezones. So, I've solved this by setting ENV TZ=UTC in the Dockerfile explicitly.

@danmoz
Copy link
Author

danmoz commented May 3, 2022

NB: I've pushed this branch as an image to danmorrison/aws-google-auth for testing purposes.

@danmoz danmoz marked this pull request as draft May 3, 2022 21:07
@nonspecialist
Copy link
Contributor

hey @danmoz I've made a couple of minor updates on https://github.com/cevoaustralia/aws-google-auth/tree/feature/update-to-alpine-3.15 which brings us up to 3.15 for the Docker image; I've pushed it to https://hub.docker.com/layers/aws-google-auth/cevoaustralia/aws-google-auth/0.0.38-test/images/sha256-76d56b96c7a073b65836da5fdb628da408c7e3238aeaaa04976e2a323161fa94?context=explore and also adjusted the Dockerfile somewhat to reduce the size of the image (now 58MB compressed); however, I don't have a config to validate it. If you could give it a whirl and let us know if it works for you, I'll merge in the updates and promote the image to latest.

@danmoz
Copy link
Author

danmoz commented May 4, 2022

Yep works fine, and the container is tiny! But it raises the UserWarning I noticed above:

/usr/lib/python3.9/site-packages/tzlocal/unix.py:177: UserWarning: Can not find any timezone configuration, defaulting to UTC.

It would be nice to suppress this, would you consider adding ENV TZ=UTC to Dockerfile in your branch before merging?

@redterror
Copy link

To pile on, I had success with this on python:3.10-alpine3.16, which is just about the latest.

@nonspecialist nonspecialist mentioned this pull request Oct 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santoshamohan santoshamohan santoshamohan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danmoz @nonspecialist @redterror @santoshamohan